-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enumerate variables needed by the HTCondor workflow #376
base: master
Are you sure you want to change the base?
Conversation
instead enumerate the variables we want to propagate from the submit environment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 50.27% 49.65% -0.62%
==========================================
Files 60 60
Lines 8677 8824 +147
==========================================
+ Hits 4362 4381 +19
- Misses 4315 4443 +128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@duncanmmacleod Thanks, do we also need |
I don't see any references to |
@duncanmmacleod the reason I ask is because the code wants to get the conda environment used at the time pages are generated. Like here: https://github.com/gwdetchar/gwdetchar/blob/f79547a178c16b9a6b9626d23d656fb025c10338/gwdetchar/io/html.py#L51. Wouldn't this mean we need |
so that it is available in conda to generate the package list
I have added |
This PR closes #375 by replacing the use of
getenv=true
with a hardcoded set of environment variables to pass through from the submit environment.